-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publishing workflow; update workflow, dependencies, tasks, docs #147
Conversation
62904e8
to
6eb3db4
Compare
…o allow early failures
e8eb715
to
1ea8f61
Compare
…n the readme and CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chunky! But all looks very sensible to me.
R.e. whether moving linting from npm test
to npm run lint
would be a breaking change, I don't think so. Even if it was a big change (like removing it entirely or whatever), we don't get enough contributions to webservice for anyone to actually notice it, IMO. I'll defer to the two Js if they have a different opinion, though.
Thanks @hollsk. I do think the |
This PR adds a publishing workflow and makes several other updates. It's designed to be the final rehabilitation PR before the versioning PR for
[email protected]
, which will be the final minor version before5
(which will usepa11y@7
).Changes
publish.yml
: this is mostly a duplicate of the common implementation described in:pa11y-webservice@4
supports. A higher version would probably be fine but we're still on lockfile v1 here. Thanks for making me think about this @jpw.tests.yml
workflow updatesmain
instead ofmaster
npm ci
instead ofnpm i
npm ci
can already be seen to be heremake ci
, which wasn't being used by CInpm test
sincelint
has moved intonpm run lint
(these weren't being used by CI either and this all might be updated further for v5)npm test
constitutes a breaking change please let me know and I'll restore it for this minor version. @hollsk @josebolosREADME.md
: substantially rewritten, including:pally-lint-config@3
, all minor compared to @sudheesh001's work earliermaster
has also been renamed tomain
in settings as part of:main
frommaster
org#19