[P4TC] Align key components to the nearest 8-bit size #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbnogueira
reviewed
Nov 21, 2024
vbnogueira
reviewed
Nov 25, 2024
vbnogueira
reviewed
Nov 27, 2024
vbnogueira
reviewed
Dec 4, 2024
vbnogueira
reviewed
Dec 5, 2024
|
As we discussed on the meeting, here's an example that shows the sum bug sum_example.tar.gz |
komaljai
force-pushed
the
align_key_bytewise
branch
2 times, most recently
from
cb20ec1 to
e5a365e
Compare
komaljai
force-pushed
the
align_key_bytewise
branch
from
e5a365e to
889848e
Compare
|
The PR looks ok, but can you rebase on top of main when you have some time? |
komaljai
force-pushed
the
align_key_bytewise
branch
3 times, most recently
from
998f749 to
ffca7b6
Compare
komaljai
requested review from
vbnogueira and
fruffy
and removed request for
vbnogueira
|
Hi @vbnogueira , @fruffy , Can you review the PR once? |
Sorry, we got a bit overwhelmed, but will do today |
vbnogueira
reviewed
Jan 14, 2025
komaljai
force-pushed
the
align_key_bytewise
branch
from
ffca7b6 to
3f9f128
Compare
Signed-off-by: Komal, Jain <[email protected]>
komaljai
force-pushed
the
align_key_bytewise
branch
from
3f9f128 to
1234582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, whenever there is a key component that is a bit-type which doesn't correspond to primitive C type (u8, u16, u32, ...),
the compiler generates it as using the closest primitive C type that is larger then X in bit
For example -
dest_op here is converted into u32 like below -
This won't work, because the P4TC side is expecting the bit<24> (
dest_op) to be contained in3 bytesand not 4. All key components are expected to be 8-bit aligned. The new declaration for 'dest_op' would be -For all operations, compiler will call function 'getPrimitiveXX()' which will convert u8[] into primitive type (u32 or u64).
For reverse assignment operations compiler calls 'storePrimitiveXX()' which converts primitive types to u8 [ ] array.
@vbnogueira @jhsmt