Support palm rejection on some "minimal capability" trackpads #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently purchased a System76 Pangolin (pang11), which is a rebranded Clevo NL50NU. I started using xf86-input-mtrack for inertial scrolling support, but found that several features don't work with my touchpad. One such feature was palm rejection. The touchpad on my computer identifies as
After using
evtest
, I noticed this this touchpad is, well, pretty dumb. The only things that it really supports is absolute value multi-touch (no pressure, touch size, etc.) and the multitouch "TOOL_TYPE" property. The TOOL_TYPE property is changed when the touchpad detects a palm. On a normal touch, the value is TOOL_TYPE=0, but when a palm is placed on the touchpad, it shows TOOL_TYPE=2. I haven't figured out if TOOL_TYPE=1 is even possible, but despite my efforts, I have yet to see it.That means, that for this touchpad, normal palm rejection won't work properly -- there is no size attribute given to calculate a palm ratio. So, I modified the driver to take into account the TOOL_TYPE for palm rejection on this dumb trackpad. The changes only apply to trackpads without pressure/size information and that also expose a TOOL_TYPE attribute.
Of course, this is tested and working on my trackpad now.
Trackpad information: