Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: Support building with -Dc_std=c99 #654

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

ueno
Copy link
Member

@ueno ueno commented Aug 4, 2024

The current checks for some functions and types do not work due to missing definition of _GNU_SOURCE or _XOPEN_SOURCE.

ueno added 4 commits August 4, 2024 09:18
This pulls in CRYPTOKI_GNU definitions moved to <p11-kit/p11-kit.h> in
commit 5332245.

Signed-off-by: Daiki Ueno <[email protected]>
Otherwise it cannot detect either version of strerror_r, when compiled
with -Dc_std=c99.

Signed-off-by: Daiki Ueno <[email protected]>
Otherwise the function is not detected when compiled with -Dc_std=c99.

Signed-off-by: Daiki Ueno <[email protected]>
Otherwise neither locale_t, newlocale, nor strerror_l is detected
under -Dc_std=c99.

Signed-off-by: Daiki Ueno <[email protected]>
@coveralls
Copy link

Coverage Status

coverage: 69.537% (+0.004%) from 69.533%
when pulling 2b5105f on ueno:wip/dueno/c99
into 5332245 on p11-glue:master.

@ueno ueno requested a review from ZoltanFridrich August 24, 2024 05:10
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
The change looks good.

@ueno ueno merged commit e6c6972 into p11-glue:master Aug 28, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants