rpc: Fix serialization of NULL mechanism pointer #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
force-pushed
the
wip/dueno/mech-fixes
branch
2 times, most recently
from
36da777 to
a146cfd
Compare
ueno
force-pushed
the
wip/dueno/mech-fixes
branch
from
a146cfd to
a4a88f1
Compare
A NULL mechanism pointer is valid for C_*Init functions to cancel the operation. Since 852ccd8 we encoded it with a CK_MECHANISM_TYPE 0 as an indicator, though it clashes with CKM_RSA_PKCS_KEY_PAIR_GEN (0). This patch changes the encoding to use a special value (0xffffffff) to indicate that and also properly advance the offset when reading. Signed-off-by: Daiki Ueno <[email protected]>
ueno
force-pushed
the
wip/dueno/mech-fixes
branch
from
a4a88f1 to
6847704
Compare
ZoltanFridrich
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A NULL mechanism pointer is valid for C_*Init functions to cancel the
operation. Since 852ccd8 we encoded it with a CK_MECHANISM_TYPE 0 as
an indicator, though it clashes with CKM_RSA_PKCS_KEY_PAIR_GEN (0).
This patch changes the encoding to use a special value (0xffffffff) to
indicate that and also properly advance the offset when reading.