Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Run tests using SoftHSM after installation #596

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

ueno
Copy link
Member

@ueno ueno commented Oct 27, 2023

This makes the unit tests self-contained so all possible code paths are exercised without optional packages installed. The integration tests against SoftHSM can still run after installation, through "make installcheck" or running the scripts manually.

Fixes: #593

@ueno ueno force-pushed the wip/dueno/installed-tests branch 3 times, most recently from 37855c5 to b8d041a Compare October 28, 2023 00:01
@ueno ueno changed the title tests: Turn tests using SoftHSM into installed-tests tests: Run tests using SoftHSM after installation Oct 28, 2023
@ueno ueno force-pushed the wip/dueno/installed-tests branch 10 times, most recently from a774c96 to 27e86cb Compare October 30, 2023 04:42
This makes the unit tests self-contained so all possible code paths
are exercised without optional packages installed.  The integration
tests against SoftHSM can still run after installation, through "make
installcheck" or running the scripts manually.

Signed-off-by: Daiki Ueno <[email protected]>
@ueno ueno force-pushed the wip/dueno/installed-tests branch from 27e86cb to 3ece485 Compare October 30, 2023 05:14
@ueno ueno requested a review from ZoltanFridrich October 30, 2023 05:45
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks good!

@ueno
Copy link
Member Author

ueno commented Oct 30, 2023

Thanks for the review!

@ueno ueno merged commit 72ed0c2 into p11-glue:master Oct 30, 2023
14 checks passed
@ZoltanFridrich ZoltanFridrich added this to the 0.25.2 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make separation of unit tests / integration tests clearer
2 participants