Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iter: Add option to stop at token with active session #590

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

ueno
Copy link
Member

@ueno ueno commented Oct 19, 2023

The commit fd7c819 introduced a slight backward incompatibility to the P11KitIter behavior when iterating with P11_KIT_ITER_WITH_TOKENS: previously it stopped before opening a token, while now it stops after that.

This adds a compatibility measure so those two are distinguishable with an explicit flag P11_KIT_ITER_WITH_SESSIONS and a kind P11_KIT_ITER_KIND_SESSION.

Related: #589

@coveralls
Copy link

Coverage Status

coverage: 69.35% (-0.02%) from 69.369% when pulling c9de401 on ueno:wip/dueno/iter-fixes into e5f0be3 on p11-glue:master.

Copy link
Contributor

@ZoltanFridrich ZoltanFridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

p11-kit/iter.c Show resolved Hide resolved
The commit fd7c819 introduced a
slight backward incompatibility to the P11KitIter behavior when
iterating with P11_KIT_ITER_WITH_TOKENS: previously it stopped before
opening a token, while now it stops after that.

This adds a compatibility measure so those two are distinguishable
with an explicit flag P11_KIT_ITER_WITH_SESSIONS and a kind
P11_KIT_ITER_KIND_SESSION.

Signed-off-by: Daiki Ueno <[email protected]>
@ueno ueno force-pushed the wip/dueno/iter-fixes branch from c9de401 to 8767007 Compare October 19, 2023 10:30
@ueno ueno merged commit cced2d9 into p11-glue:master Oct 19, 2023
14 checks passed
@ZoltanFridrich ZoltanFridrich added this to the 0.25.1 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants