Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for importing objects into a PKCS#11 token #588

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

ZoltanFridrich
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich commented Oct 16, 2023

The import-object command allows users to import a certificates or public keys into a pkcs#11 token by providing a PEM file.

$ p11-kit import-object --login --label=MyCert --file=MyCert.pem 'pkcs11:token=MyToken'

Closes #394

@ZoltanFridrich ZoltanFridrich self-assigned this Oct 16, 2023
@ZoltanFridrich ZoltanFridrich marked this pull request as draft October 16, 2023 14:48
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 2 times, most recently from 4463c20 to 438c3d0 Compare October 16, 2023 15:08
@coveralls
Copy link

coveralls commented Oct 16, 2023

Coverage Status

coverage: 69.349% (+0.001%) from 69.348% when pulling 73ae998 on ZoltanFridrich:zfridric_devel into cced2d9 on p11-glue:master.

@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 5 times, most recently from 9c9b728 to af1c5a1 Compare October 18, 2023 14:14
@ueno ueno modified the milestone: 0.25.1 Oct 18, 2023
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 2 times, most recently from 54b3c52 to 20a4d6c Compare October 19, 2023 11:58
@ZoltanFridrich ZoltanFridrich marked this pull request as ready for review October 19, 2023 11:59
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 2 times, most recently from 02e151a to 9ff99f5 Compare October 19, 2023 12:57
@ZoltanFridrich ZoltanFridrich requested a review from ueno October 19, 2023 12:58
common/compat.c Outdated Show resolved Hide resolved
p11-kit/import-object.c Outdated Show resolved Hide resolved
p11-kit/import-object.c Outdated Show resolved Hide resolved
p11-kit/import-object.c Outdated Show resolved Hide resolved
p11-kit/import-object.c Outdated Show resolved Hide resolved
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 3 times, most recently from 4fc19e2 to 2d29a62 Compare October 19, 2023 15:04
@ZoltanFridrich ZoltanFridrich requested a review from ueno October 19, 2023 15:05
p11-kit/import-object.c Outdated Show resolved Hide resolved
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except a minor nit.

The import-object command allows users to import certificates or
public keys into a pkcs#11 token by providing a PEM file.

usage: p11-kit import-object --file=<file.pem> [--label=<label>]
[--login] pkcs11:token

Signed-off-by: Zoltan Fridrich <[email protected]>
@ZoltanFridrich ZoltanFridrich merged commit 6bacb56 into p11-glue:master Oct 20, 2023
14 checks passed
@ZoltanFridrich ZoltanFridrich added this to the 0.25.1 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic key and object manipulation subcommands to p11-kit
3 participants