-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command for importing objects into a PKCS#11 token #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoltanFridrich
force-pushed
the
zfridric_devel
branch
2 times, most recently
from
October 16, 2023 15:08
4463c20
to
438c3d0
Compare
ZoltanFridrich
force-pushed
the
zfridric_devel
branch
5 times, most recently
from
October 18, 2023 14:14
9c9b728
to
af1c5a1
Compare
ZoltanFridrich
force-pushed
the
zfridric_devel
branch
2 times, most recently
from
October 19, 2023 11:58
54b3c52
to
20a4d6c
Compare
ZoltanFridrich
force-pushed
the
zfridric_devel
branch
2 times, most recently
from
October 19, 2023 12:57
02e151a
to
9ff99f5
Compare
ueno
reviewed
Oct 19, 2023
ZoltanFridrich
force-pushed
the
zfridric_devel
branch
3 times, most recently
from
October 19, 2023 15:04
4fc19e2
to
2d29a62
Compare
ueno
reviewed
Oct 19, 2023
ueno
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except a minor nit.
The import-object command allows users to import certificates or public keys into a pkcs#11 token by providing a PEM file. usage: p11-kit import-object --file=<file.pem> [--label=<label>] [--login] pkcs11:token Signed-off-by: Zoltan Fridrich <[email protected]>
ZoltanFridrich
force-pushed
the
zfridric_devel
branch
from
October 20, 2023 08:16
2d29a62
to
73ae998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import-object command allows users to import a certificates or public keys into a pkcs#11 token by providing a PEM file.
$ p11-kit import-object --login --label=MyCert --file=MyCert.pem 'pkcs11:token=MyToken'
Closes #394