p11-kit commands: Add --login option #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -60,20 +65,20 @@ | |||
| char *argv[]); | |||
|
|
|||
| static int | |||
| list_profiles (const char *token_str) | |||
| list_profiles (const char *token_str, | |||
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
ueno
force-pushed
the
wip/dueno/login
branch
8 times, most recently
from
332f780 to
9507f67
Compare
This make P11KitIter use the P11KitPin interface to retrieve PIN if the "pin-source" attribute is available in the matching URI. Signed-off-by: Daiki Ueno <[email protected]>
ZoltanFridrich
requested changes
Oct 6, 2023
|
does this also resolve #564? |
This is now done in P11KitIter as needed. Signed-off-by: Daiki Ueno <[email protected]>
This adds support for prompting PIN on the terminal, through the readpassphrase function borrowed from libbsd. Signed-off-by: Daiki Ueno <[email protected]>
Previously those tools determined whether a login is necessary by checking the presence of "pin-value" query attribute in the URI. It was too implicit and against modern security practice. This instead asks users to specify --login option and if no "pin-value" is given, it tries to read a PIN from the terminal. Signed-off-by: Daiki Ueno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, those tools determined whether a login is necessary by
checking the presence of "pin-value" query attribute in the URI. It
was too implicit and against modern security practice. This instead
asks users to specify --login option and if no "pin-value" is given,
it tries to read a PIN from the terminal.
Fixes: #570