Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p11-kit generate-keypair: Support EdDSA key generation #582

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

ueno
Copy link
Member

@ueno ueno commented Oct 1, 2023

Also add tests for the p11-kit generate-keypair command using SoftHSM2.

@ueno ueno force-pushed the wip/dueno/generate-keypair-eddsa branch 3 times, most recently from cf68c2e to a434bc8 Compare October 4, 2023 06:38
@coveralls
Copy link

Coverage Status

coverage: 69.258% (+0.007%) from 69.251% when pulling a434bc8 on ueno:wip/dueno/generate-keypair-eddsa into aedbab2 on p11-glue:master.

@ueno ueno requested a review from ZoltanFridrich October 4, 2023 07:02
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice.

@ueno ueno force-pushed the wip/dueno/generate-keypair-eddsa branch from a434bc8 to 6941c02 Compare October 4, 2023 09:11
ueno added 2 commits October 4, 2023 18:18
This adds support for generating EdDSA keys with the p11-kit
generate-keypair command.  Aside from that tests are added using
SoftHSM to exercise all the supported algorithms.

Signed-off-by: Daiki Ueno <[email protected]>
This updates the base image to Fedora 38 from Fedora 34, and install
the p11-kit-devel and softhsm packages, which are needed to test the
p11-kit generate-keypair command.

Signed-off-by: Daiki Ueno <[email protected]>
@ueno ueno force-pushed the wip/dueno/generate-keypair-eddsa branch from 6941c02 to 65de81e Compare October 4, 2023 09:19
@ueno ueno merged commit 1cec784 into p11-glue:master Oct 4, 2023
14 checks passed
@ueno ueno added this to the 0.25.1 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants