list-modules: Do not embed module-name and module-path in URL #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we no longer call `set -e`, exit status of each command invocation should be checked manually. Signed-off-by: Daiki Ueno <[email protected]>
ZoltanFridrich
approved these changes
Sep 18, 2023
module-name and module-path are query attributes, which are to modify the default settings (RFC 7512 section 2.4). As p11-kit manages the default configuration, it shouldn't print them as part of the token URL. This instead prints the absolute path of each module in a separate field of the output. Signed-off-by: Daiki Ueno <[email protected]>
ueno
force-pushed
the
wip/dueno/list-modules
branch
from
89c2115 to
14763e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module-name and module-path are query attributes, which are to modify
the default settings (RFC 7512 section 2.4). As p11-kit manages the
default configuration, it shouldn't print them as part of the token
URL. This instead prints the absolute path of each module in a
separate field of the output.