Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 improve code and analysis #65

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Conversation

garak
Copy link
Member

@garak garak commented Jan 22, 2024

  • fix some minor annoyances in the README
  • update some vendor minor versions
  • improve php-cs-fixer configuration
  • improve the code, reducing phpstan errors at level 8 from 29 to 13

notice that the phpstan level is not changed in this PR, to avoid CI failures. I temporarily increased the level to 8, ran phpstan and then reverted the level to 7.

@garak garak requested a review from akondas January 22, 2024 16:21
@garak garak merged commit eaa2a54 into p-chess:master Sep 15, 2024
5 checks passed
@garak garak deleted the improve-analysis branch September 15, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant