Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] oxigen_stock_barcodes_gs1: add 21 ia (serial number) #141

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

FrankC013
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 48.78%. Comparing base (3d00036) to head (0cd1a56).
Report is 2 commits behind head on 14.0.

Files Patch % Lines
...n_stock_barcodes_gs1/wizard/stock_barcodes_read.py 11.11% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             14.0     #141      +/-   ##
==========================================
- Coverage   50.21%   48.78%   -1.44%     
==========================================
  Files          83       83              
  Lines         910      945      +35     
  Branches      202      215      +13     
==========================================
+ Hits          457      461       +4     
- Misses        442      473      +31     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrankC013 FrankC013 force-pushed the 14.0-imp-oxigen_stock_barcodes_gs1-add_21_ia branch from f106bb6 to fc0ebca Compare January 5, 2024 15:28
@FrankC013 FrankC013 force-pushed the 14.0-imp-oxigen_stock_barcodes_gs1-add_21_ia branch from fc0ebca to f06ee69 Compare January 5, 2024 15:54
@FrankC013 FrankC013 requested review from eantones and removed request for eantones January 11, 2024 09:14
@FrankC013 FrankC013 force-pushed the 14.0-imp-oxigen_stock_barcodes_gs1-add_21_ia branch 2 times, most recently from 52e2b06 to 5b98985 Compare January 11, 2024 10:27
@FrankC013 FrankC013 force-pushed the 14.0-imp-oxigen_stock_barcodes_gs1-add_21_ia branch from 5b98985 to f21590c Compare January 11, 2024 10:29
Copy link
Contributor

@eantones eantones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FrankC013 FrankC013 force-pushed the 14.0-imp-oxigen_stock_barcodes_gs1-add_21_ia branch 2 times, most recently from 001ee08 to e2e08fd Compare February 20, 2024 09:43
Copy link
Contributor

@eantones eantones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@eantones eantones force-pushed the 14.0-imp-oxigen_stock_barcodes_gs1-add_21_ia branch from e2e08fd to 493e035 Compare March 4, 2024 21:36
@eantones eantones force-pushed the 14.0-imp-oxigen_stock_barcodes_gs1-add_21_ia branch from 3019cda to 456abe7 Compare March 4, 2024 21:55
@FrankC013 FrankC013 force-pushed the 14.0-imp-oxigen_stock_barcodes_gs1-add_21_ia branch from 9e33477 to 0cd1a56 Compare March 13, 2024 12:01
@eantones eantones merged commit d2a0689 into 14.0 Aug 7, 2024
4 of 6 checks passed
@eantones eantones deleted the 14.0-imp-oxigen_stock_barcodes_gs1-add_21_ia branch August 7, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants