Support external references #621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
reviewed
Jul 3, 2024
typify-impl/Cargo.toml
Outdated
Comment on lines
23
to
24
| pathdiff = "0.2.1" | ||
| iref = "3.1.4" |
There was a problem hiding this comment.
the dependencies above are alpha sorted. would be good for these new ones to also be alpha sorted
jayvdb
reviewed
Jul 3, 2024
| let reader = BufReader::new(file); | ||
|
|
||
| let schema: RootSchema = serde_json::from_reader(reader).unwrap(); | ||
| // schema.schema.metadata().title = Some("Everything".to_string()); |
There was a problem hiding this comment.
commented out code in this test
… into support-external-references
…xternal-references
… into support-external-references
|
@jayvdb Bumping this |
|
@SRetip is it an idea that you resolve the merge conflicts so that the maintainers can approve and this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for issue #201.
These changes were made based on the discussion in the issue.
I understand that this pull request can be improved, and I would appreciate any feedback and thoughts on how to make it better.