-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update oximeter
and crucible
deps
#679
Conversation
This pulls in omicron#5340, which lays some groundwork for larger changes to the oximeter producer-collector interface coming later.
These are all the crucible changes included here: Update oximeter dependency (#1244) We should rope in @jmpesp and be sure Omicron is ready to take the crucible 1215 PR. |
Thanks @leftwo. @jmpesp I've added you as a reviewer. I put this up to include a small change to the |
Sorry I missed these notifications - yes, Omicron is ready: oxidecomputer/omicron#5135 went in before 1215 did. |
Let's get this in (and bump the pinned version in omicron) since the upcoming customer release has a shorter runway this time. |
I'm fine with the changes, and will hit merge, but for some reason I'm getting a bunch of warning when I compile this branch locally (on Atrium). I'm going to spend a little time and see if I can figure out why, but I suspect it's something local to my setup. An example is:
|
This might explain my issues:
This works:
|
This pulls in omicron#5340, which lays some groundwork for larger changes to the oximeter producer-collector interface coming later.