Add kind field to metric registration request #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the first Propolis PR in a sequence intended to add a new parameter to a Nexus internal API. The first PR is oxidecomputer/omicron#4497, after which I'll merge oxidecomputer/crucible#1039 and then this one. The Omicron PR adds an optional parameter indicating the kind of metric producer one registers as. A follow-up commit in Omicron will make that parameter optional, once the out-of-tree consumers all supply it. |
bnaecker
force-pushed
the
add-optional-producer-kind-field
branch
from
72eba96 to
2007850
Compare
bnaecker
force-pushed
the
add-optional-producer-kind-field
branch
from
2007850 to
95a5e99
Compare
|
The first commit in Omicron is ready to merge, so I'm marking this ready for review. I'll update the Crucible revision this points to and Omicron branches as well, once they land in that repo's |
pfmooney
approved these changes
Nov 21, 2023
Also update OpenAPI document with falcon feature enabled, using the feature to select the document against which the test compares.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.