Update to dist 0.26 and build on Alma 8 #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our linux-gnu builds use the default Ubuntu 20.04 runner image. This uses a glibc version more recent than RHEL 8-derived distros, making this copy of the binary unusable on those systems. While CentOS 8 was EOL'd in 2021, RHEL 8 and its clones like Rocky 8 will still be updated until 2029, and we have customers using these distros today. The musl build does work on RHEL 8, but we've encountered some issues with their getaddrinfo(3) implementation that make this alternative a poor experience for users. Update to `dist` v0.26, which moves its configuration out of `Cargo.toml` and into a separate `dist-workspace.toml` file. Also update the linux-gnu target to run in an Alma Linux 8 container using a Python manylinux[0] image intended for building widely compatible binaries. [0] https://github.com/pypa/manylinux
ahl
approved these changes
Dec 19, 2024
|
Is there customization beyond running cargo dist? |
manylinux is hosted on quay.io, not dockerhub.
No, the config changes in this PR, other than setting the container, were all autogenerated by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our linux-gnu builds use the default Ubuntu 20.04 runner image. This uses a glibc version more recent than RHEL 8-derived distros, making this copy of the binary unusable on those systems. While CentOS 8 was EOL'd in 2021, RHEL 8 and its clones like Rocky 8 will still be updated until 2029, and we have customers using these distros today. The musl build does work on RHEL 8, but we've encountered some issues with their getaddrinfo(3) implementation that make this alternative a poor experience for users.
Update to
distv0.26, which moves its configuration out ofCargo.tomland into a separatedist-workspace.tomlfile. Also update the linux-gnu target to run in an Alma Linux 8 container using a Python manylinux image intended for building widely compatible binaries.