Allow user to select threads for image upload #900
Conversation
|
Why would we expect users to set this value? And how would they know what value to set it to? Should the CLI typically try to upload as fast as possible? If we're doing this because we've found that more threads increases upload speed for us, let's figure out something that's going to good in most cases. If we're trying to limit bandwidth consumption rather than maximize it, let's figure out the right knob to effect that. |
|
While users could set this value themselves, I don't know how they would know what to set it to without experimenting. The purpose here is mainly to work around oxidecomputer/omicron#6771 that we see in CI. |
cli/src/cmd_disk.rs
Outdated
| /// The number of parallel threads to use during upload | ||
| #[clap(long, default_value = "8")] | ||
| thread_count: usize, |
There was a problem hiding this comment.
| /// The number of parallel threads to use during upload | |
| #[clap(long, default_value = "8")] | |
| thread_count: usize, | |
| /// The degree of parallelism to use during upload | |
| #[clap(long, default_value = "8", hide = true)] | |
| parallelism: usize, |
Let's rename this to be more accurate (even if the underlying API is a little imprecise) and let's hide it so that customer aren't surprised when we remove it.
Added an option,
thread-countto the image upload that allows a user to choose how many threads to create.