Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/n] [omicron-package] better error messages around target #7287

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Dec 20, 2024

  • If no target is specified, don't print a confusing the name '{name}' is reserved message.
  • For target delete, if removing the file failed, print the corresponding error message.

Depends on #7285.

Created using spr 1.3.6-beta.1

[skip ci]
Created using spr 1.3.6-beta.1
@sunshowers sunshowers changed the base branch from sunshowers/spr/main.2n-omicron-package-better-error-messages-around-target to main December 20, 2024 21:13
Created using spr 1.3.6-beta.1
@sunshowers sunshowers enabled auto-merge (squash) December 20, 2024 21:15
@sunshowers sunshowers merged commit 6672f1f into main Dec 20, 2024
16 checks passed
@sunshowers sunshowers deleted the sunshowers/spr/2n-omicron-package-better-error-messages-around-target branch December 20, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants