Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Zone UUID as Dataset UUID in RSS #7269

Closed
wants to merge 1 commit into from

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Dec 18, 2024

Potential fix for #7265

@smklein
Copy link
Collaborator Author

smklein commented Dec 18, 2024

I think this PR, as-is, is still wrong -- I think that it also needs to ensure all future dataset UUIDs associated with zones get a value of "Dataset UUID" set to the "Zone UUID", otherwise the sled-agent overwrite will ignore the "new" blueprint value:

Source of "sled agent overwrite":
https://github.com/oxidecomputer/omicron/blob/main/sled-agent/src/sled_agent.rs#L965-L970

Spots in reconfigurator planning where we'd need to also ensure that the "new dataset UUIDs == zone UUIDs":

rng.next_dataset()
}
} else {
rng.next_dataset()

@smklein
Copy link
Collaborator Author

smklein commented Dec 18, 2024

Preferring to not do this solution, abandoning

@smklein smklein closed this Dec 18, 2024
@smklein smklein deleted the assign-dataset-uuid-as-zone-id branch December 18, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant