Support diffing blueprints via Diffus #7261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This is the second step in #7240. The next steps will use this support to replace our handrolled code for generating diffs and generate output from the diffus based diffs.
andrewjstone
changed the title
jgallagher
approved these changes
Dec 19, 2024
| @@ -187,6 +190,7 @@ pub struct Blueprint { | |||
| pub clickhouse_cluster_config: Option<ClickhouseClusterConfig>, | |||
|
|
|||
| /// when this blueprint was generated (for debugging) | |||
| #[diffus(ignore)] | |||
There was a problem hiding this comment.
Do we also want to ignore creator and comment? I think we don't care about those in diffs either.
There was a problem hiding this comment.
After discussion with Rain, I'm going to write a visitor. I think it's worth allowing the possibility to diff these via visitor implementations.
|
This is wonderful -- thanks again for all the work and the demo today @andrewjstone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second step in #7240.
The next steps will use this support to replace our handrolled code for generating diffs and generate output from the diffus based diffs.