Use more PhysicalDiskUuid #7163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmpesp
commented
Nov 25, 2024
| @@ -208,8 +209,10 @@ impl super::Nexus { | |||
| opctx: &'a OpContext, | |||
| disk_selector: ¶ms::PhysicalDiskPath, | |||
| ) -> Result<lookup::PhysicalDisk<'a>, Error> { | |||
| Ok(lookup::LookupPath::new(&opctx, &self.db_datastore) | |||
| .physical_disk(disk_selector.disk_id)) | |||
| // XXX how to do typed UUID as part of dropshot path? | |||
There was a problem hiding this comment.
This is one thing I didn't know how to do, or if dropshot even supported it. Comments welcome :)
There was a problem hiding this comment.
It should just work if you change the type of params::PhysicalDiskPath::disk_id to be PhysicalDiskUuid instead of Uuid. However, I'm not sure we want to: this would affect the public API and would "leak" our typed UUIDs:
--- a/openapi/nexus.json
+++ b/openapi/nexus.json
@@ -4786,8 +4786,7 @@
"description": "ID of the physical disk",
"required": true,
"schema": {
- "type": "string",
- "format": "uuid"
+ "$ref": "#/components/schemas/TypedUuidForPhysicalDiskKind"
}
}
],
@@ -22499,6 +22498,10 @@
"ram_provisioned"
]
},
+ "TypedUuidForPhysicalDiskKind": {
+ "type": "string",
+ "format": "uuid"
+ },
"NameSortMode": {
"description": "Supported set of sort modes for scanning by name only\n\nCurrently, we only support scanning in ascending order.",
"oneOf": [I vaguely remember @ahl suggesting this wasn't something we wanted, but can't find the details of that suggestion at the moment. Maybe this doesn't translate particularly well for non-Rust OpenAPI clients?
hawkw
approved these changes
Nov 25, 2024
looking into it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.