-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nexus] Support Bundle background task #7063
Open
smklein
wants to merge
29
commits into
support-bundle-simulated-implementation
Choose a base branch
from
support-bundle-bg-task
base: support-bundle-simulated-implementation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[nexus] Support Bundle background task #7063
smklein
wants to merge
29
commits into
support-bundle-simulated-implementation
from
support-bundle-bg-task
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2024
- Made an API abstraction above support bundles so it can be shared by the real/simulated sled agent - To use this API: - Refactored simulated sled agent storage APIs (internal mutability) - Changed a bunch of sled agent locks to std mutex - Implemented a "nested dataset" API in the simulated sled agent storage - Started using this simulated sled agent API in the support bundle collector background task tests
smklein
changed the base branch from
support-bundles-crdb
to
support-bundle-simulated-implementation
December 17, 2024 22:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 4 / ???
Adds a background task to manage support bundle lifecycle, and perform collection
In this PR: