Init timeseries database on connection acquisition #6878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plotnick
force-pushed
the
init-on-acquire
branch
from
3b3d00f to
91c5528
Compare
plotnick
force-pushed
the
init-on-acquire
branch
from
91c5528 to
ded7d75
Compare
plotnick
added a commit
that referenced
this pull request
Nov 19, 2024
Depends on #6894, replaces #6878, fixes #6826 on the server side. Adds a new Dropshot server, `clickhouse-admin-single`, analogous to `clickhouse-admin-keeper` and `clickhouse-admin-server` (which were split off from `clickhouse-admin` in #6837). Its sole purpose is to initialize the single-node ClickHouse database with the current Oximeter schema. We use a single in-memory lock (a `tokio::sync::Mutex`) to serialize initialization requests. Multi-node ClickHouse clusters will need something analogous as a follow-up. --------- Co-authored-by: Andrew J. Stone <[email protected]> Co-authored-by: Karen Cárcamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6745, fixes #6826 on the client side. The current implementation is a quick & dirty prototype, and copies many pieces of
impl Client; if we decide to pursue this (client-side) strategy, we can refactor more aggressively.