[do not land] handle runtime shutdown more gracefully #6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
sunshowers
commented
Oct 15, 2024
| @@ -276,6 +276,12 @@ impl Error { | |||
| Error::ServiceUnavailable { internal_message: message.to_owned() } | |||
| } | |||
|
|
|||
| pub fn runtime_shutdown() -> Error { | |||
| Error::ServiceUnavailable { | |||
There was a problem hiding this comment.
I'd make this another variant so it can be detected by callers.
|
This would be nice and I think there's a path here, but ultimately the juice doesn't seem worth the squeeze for now. Going to close this in favor of oxidecomputer/qorb#45. |
sunshowers
deleted the
sunshowers/spr/do-not-land-handle-runtime-shutdown-more-gracefully
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6505 we identified a situation where panics were occurring because the
Tokio runtime was shutting down. Making panics work better requires essentially
making all of the database code and its dependents be aware of the situation
where runtime shutdown is happening.
This is incomplete work that builds on top of oxidecomputer/async-bb8-diesel#77,
but I wanted to show the general direction we would
take here. The next step from here would probably be to detect the runtime
shutdown situation in background tasks, and change
BackgroundTask::activateto cleanly exit in those situations.
I don't think this is worth pursuing to be honest -- I'd consider this an
interesting experiment but ultimately a negative result.