Update Oximeter-related DataStore methods for incoming reconfigurator support #6518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
approved these changes
Sep 5, 2024
bnaecker
approved these changes
Sep 9, 2024
| use db::schema::oximeter::dsl; | ||
|
|
||
| dsl::oximeter | ||
| .select(( |
There was a problem hiding this comment.
Does AsExpression help here? It seems like we might be able to derive this on the ProducerEndpoint model type, and then use it here.
There was a problem hiding this comment.
I'm not sure! I tried it for a bit and couldn't get it to work; it requires also attaching a #[diesel(sql_type = Foo)] annotation, and I have no idea what to put in for Foo (a tuple of the table's columns doesn't work). Do we use AsExpression on structs with multiple fields anywhere?
There was a problem hiding this comment.
Good question, I don't see any such types! I don't think it's a huge deal, it's just frustrating to have to rename all the columns explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new
DataStoremethods:oximeter_delete(soft deletes an oximeter instance, which also requires a small migration to add atime_deletedcolumn)oximeter_reassign_all_producers(reassigns all metric producers from one oximeter instance to random other instances)and updates existing methods to account for the possibility that an oximeter instance may have been deleted (e.g., don't return deleted instances when listing).
There are no callers of these methods in this PR, but there will be in the upcoming reconfigurator-can-rebalance-oximeter PR.