don't run GHA workflows on tag pushes #6510
Conversation
The purpose of a system |
| on: [ push, pull_request ] | ||
| on: | ||
| push: | ||
| branches: |
There was a problem hiding this comment.
So if I understand correctly, the reason this is required is because GitHub ridiculously includes tags in the push event, and we had no filter at all here to begin with, but now we explicitly restrict it to this set of branches?
Do we want to, perhaps, do it for all branches (just not tags)? That's how buildomat works for example.
There was a problem hiding this comment.
I'm fine either way; I think the vast majority of push events to other branches are redundant with the pull request events, and we need the pull request events to handle PRs from forks.
Another approach might be to run the workflow on any push to a branch, and only run pull request workflows if they come from a fork. I don't know if that's possible.
There was a problem hiding this comment.
In practice I think we would only particularly care if an artefact we expect to download and run (for a non-PR work in progress branch) was missing. Those come from buildomat, not GHA, so I expect making this change is likely fine as-is!
There was a problem hiding this comment.
(have you had a chance to run the numbers on cost/time savings if buildomat did filter out non-PR branches, btw?)
| on: [ push, pull_request ] | ||
| on: | ||
| push: | ||
| branches: |
There was a problem hiding this comment.
(have you had a chance to run the numbers on cost/time savings if buildomat did filter out non-PR branches, btw?)
Per the branching experiment review we are about to begin in the control plane huddle.
pushmode when pushing tomainor any branch matching the globrel/**.mainbranch.This is a draft because we cannot merge it untilEDIT: Maybe this isn't a thing? GitHub confuses me.Rust / clippy-lint (push)andRust / check-style (push)are removed from the required checks. (Thepull_requestversions should remain required.)