Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused name_or_id query param on bgp announce set list #6498

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

david-crespo
Copy link
Contributor

Closes #6467

Happy to throw this out @internet-diglett if it conflicts with anything you're doing, but it's small enough that I think you might be able to just merge it into yours.

@internet-diglett
Copy link
Contributor

Probably makes sense to update the name_or_id to announce_set while we're here:

#[endpoint {
method = DELETE,
path = "/v1/system/networking/bgp-announce-set/{name_or_id}",
tags = ["system/networking"],
}]
async fn networking_bgp_announce_set_delete(
rqctx: RequestContext<Self::Context>,
path_params: Path<params::BgpAnnounceSetSelector>,
) -> Result<HttpResponseUpdatedNoContent, HttpError>;
// TODO: is pagination necessary here? How large do we expect the list of
// announcements to become in real usage?
/// Get originated routes for a specified BGP announce set
#[endpoint {
method = GET,
path = "/v1/system/networking/bgp-announce-set/{name_or_id}/announcement",
tags = ["system/networking"],
}]
async fn networking_bgp_announcement_list(
rqctx: RequestContext<Self::Context>,
path_params: Path<params::BgpAnnounceSetSelector>,
) -> Result<HttpResponseOk<Vec<BgpAnnouncement>>, HttpError>;

Copy link
Contributor

@internet-diglett internet-diglett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small suggestion since we're in here. Tested this in a4x2 and everything appears to work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/v1/system/networking/bgp-announce-set has unnecessary name_or_id query param
2 participants