[nexus] Expand BlueprintDiff to identify changed datasets #6481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
changed the title
andrewjstone
approved these changes
Sep 4, 2024
nexus/reconfigurator/planning/tests/output/planner_nonprovisionable_2_2a.txt
Show resolved
Hide resolved
smklein
commented
Nov 7, 2024
| @@ -1755,6 +1772,79 @@ mod test { | |||
| logctx.cleanup_successful(); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_dataset_settings_modified_in_place() { | |||
| static TEST_NAME: &str = "planner_dataset_settings_modified_in_place"; | |||
There was a problem hiding this comment.
I added this test to give an example of "what the diff looks like when a dataset is modified".
planner_dataset_settings_modified_in_place_1_2.txt contains this example
smklein
commented
Nov 7, 2024
Comment on lines
+80
to
+81
| * oxp_f843fb62-0f04-4c7d-a56f-62531104dc77/crypt/debug 2011121d-b454-41c5-9062-18fa04ee1d52 - none - 1 GiB off | ||
| └─ + 100 GiB + none |
There was a problem hiding this comment.
(This is the notable bit)
andrewjstone
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "datasets" to
BlueprintDiff.The
BlueprintDifftool already allows comparing blueprints and collections, this PR expands that comparisonto also display differences in datasets.
Additionally, this PR:
ExampleSystem's system descriptionBlueprintDiffvalues in reconfigurator tests