Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out generic activate_background_task #6460

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jmpesp
Copy link
Contributor

@jmpesp jmpesp commented Aug 27, 2024

Factor out a function that, given the name of a background task, activates it and runs it to completion (in a test context).

Factor out a function that, given the name of a background task,
activates it and runs it to completion (in a test context).
@jmpesp jmpesp requested a review from hawkw August 27, 2024 20:49
@jmpesp
Copy link
Contributor Author

jmpesp commented Aug 27, 2024

(I'm going to end up needing this or something like this to test fixes for racing region and region snapshot replacements, so here we are haha)

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I actually was about to do something very similar for some tests I'm working on, too!

@jmpesp jmpesp enabled auto-merge (squash) August 27, 2024 21:42
@jmpesp jmpesp merged commit c313f99 into oxidecomputer:main Aug 27, 2024
17 checks passed
@jmpesp jmpesp deleted the factor_out_activate_bg_task branch August 28, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants