-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtual disk timeseries schema #6420
Conversation
This adds a new set of timeseries that track block operations on virtual disks. This builds on and replaces the pre-existing Crucible data, adding more information about the disk and instance it's attached to. It also tracks I/O latencies and sizes in histograms.
I've used this while testing oxidecomputer/propolis#746, which has examples of the data this publishes. But to summarize, we have
The thing I'd like some input on is related to #5267. I had originally put the sled identifiers on this timeseries. Adam raised some concerns about actionability of those fields; how they might confuse developers, who don't really know about and can't see the sleds; and that it will complicate the rough idea for an authz model. I agree with those points, but would appreicate some other perspectives too. |
It occurs to me we should reduce the lowest I/O size histogram bin to 512 bytes. That's the minimum block size the control plane allows, so should be the smallest actual block operation size. |
Holding off on this while we sort out how to cut the R10 release branch / commit with the new process. |
This adds a new set of timeseries that track block operations on virtual disks. This builds on and replaces the pre-existing Crucible data, adding more information about the disk and instance it's attached to. It also tracks I/O latencies and sizes in histograms.