Use BlueprintZoneConfig in RSS service plan

[andrewjstone]

In anticipation of adding more BlueprintZoneConfig variants with more auxiliary information, we stop converting from OmicronZoneConfig to BlueprintZoneConfig which is not going to be feasible for much longer.

Instead we change the one production code place we do this, RSS, to directly construct BlueprintZoneConfig structs rather than do the conversion.

This has some ripple effects, and results in a new persistent v4 sled service plan.

There is one test that still does this conversion, but the function that does it is now moved into that test module and commented heavily. We hope to remove it shortly.

[andrewjstone]

This is not as daunting as it looks. 1000 lines of it is a generated json file.

[jgallagher]

Looks great; thanks for cleaning up this mess I left behind.

Out of an abundance of paranoia, have you run through RSS on this branch on london or madrid? (Does a4x2 go through this same code path? I forget when it converges back with normal setup.)

[andrewjstone]

Thanks for the review @jgallagher. Much appreciated.

Looks great; thanks for cleaning up this mess I left behind.

Out of an abundance of paranoia, have you run through RSS on this branch on london or madrid? (Does a4x2 go through this same code path? I forget when it converges back with normal setup.)

I did not do that yet. I'll definitely do it before merge. I think the deploy task runs through this, but I'll run it on a4x2, which definitely runs RSS. It just does it from a config file I believe. I always wait for Handoff to Nexus complete, but I'll also double check after a run to ensure the new plan gets written.

[andrewjstone]

Thanks for the review @jgallagher. Much appreciated.

Looks great; thanks for cleaning up this mess I left behind.
Out of an abundance of paranoia, have you run through RSS on this branch on london or madrid? (Does a4x2 go through this same code path? I forget when it converges back with normal setup.)

I did not do that yet. I'll definitely do it before merge. I think the deploy task runs through this, but I'll run it on a4x2, which definitely runs RSS. It just does it from a config file I believe. I always wait for Handoff to Nexus complete, but I'll also double check after a run to ensure the new plan gets written.

I tested on a4x2 and Handoff completed successfully. I see the new rss-service-plan-v4.json and it contains an external_ip_id which only exists in the BlueprintZoneConfig.