Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check histogram bin overflow in the support type, not the power type #6409

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Check histogram bin overflow in the support type, not the power type #6409

merged 2 commits into from
Aug 23, 2024

Conversation

bnaecker
Copy link
Collaborator

Fixes #6408

@bnaecker
Copy link
Collaborator Author

Friendly ping on this one @zeeshanlakhani, I'd like to build on this to get some other testing done. Thanks!

@bnaecker bnaecker mentioned this pull request Aug 22, 2024
Merged
zeeshanlakhani
zeeshanlakhani approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@zeeshanlakhani zeeshanlakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find and fix.

@bnaecker bnaecker merged commit 02303a6 into main Aug 23, 2024
22 checks passed
@bnaecker bnaecker deleted the oh-my-histobam branch August 23, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeshanlakhani zeeshanlakhani zeeshanlakhani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Histograms should not overflow if bins fit into target type
2 participants
@bnaecker @zeeshanlakhani