-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3/n] use update engine for reconfigurator execution #6399
Merged
sunshowers
merged 14 commits into
main
from
sunshowers/spr/wip-use-update-engine-for-reconfigurator-execution
Sep 7, 2024
Merged
[3/n] use update engine for reconfigurator execution #6399
sunshowers
merged 14 commits into
main
from
sunshowers/spr/wip-use-update-engine-for-reconfigurator-execution
Sep 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
sunshowers
commented
Aug 20, 2024
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
sunshowers
changed the title
[WIP] use update engine for reconfigurator execution
[2/n] use update engine for reconfigurator execution
Aug 27, 2024
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
sunshowers
changed the title
[2/n] use update engine for reconfigurator execution
[3/n] use update engine for reconfigurator execution
Aug 27, 2024
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
sunshowers
changed the base branch from
sunshowers/spr/main.wip-use-update-engine-for-reconfigurator-execution
to
main
August 30, 2024 03:57
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nits/questions
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/wip-use-update-engine-for-reconfigurator-execution
branch
September 7, 2024 00:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to introduce the ability for the reconfigurator execution to be driven by the update engine. Doing so does add some complexity -- there's a new system driving updates -- but has several advantages that will be coming in future patches:
This is really basic so far -- for example, we don't currently report skipped steps, nor do we model nesting within the update engine. But it's a good place to get started, and we can keep enhancing this as time permits.
One change is that we now return and store a single
anyhow::Error
rather than a list of errors. If a step returns more than one error, we use a hack to combine the cause chains into a single message.To serialize errors, we use the
NestedError
that's currently inupdate-engine
. One benefit is that we now record the entire chain of error sources.Within omdb, I also switched the blueprint executor display (and nothing else so far) to use tabled for easy alignment. This is what it looks like now:
Depends on:
(
to the beginning of step indexes in the line displayer #6447