-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OxQL query response type into an object #6374
Conversation
bnaecker
commented
Aug 17, 2024
- Fixes Type returned from OxQL queries should be an object #6371
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think with #6373, OxqlQueryResult
will have to live in nexus/types/src/external_api/views.rs
, so you might as well move it there already.
Makes sense, thanks. @sunshowers should I wait until the Nexus external API sequence lands to merge this? It's not a big conflict, but I don't want to hold the train. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about landing this after #6364? (That will cause a semantic merge conflict with this PR sadly.) The rest are pretty easy to fix up, thanks!
f1fddda
to
27ff09e
Compare
I've updated this on Rain's #6364, and set this to automerge. Thanks for the reviews y'all!. |