-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3/6] [nexus-auth] move some types into nexus-types #6369
[3/6] [nexus-auth] move some types into nexus-types #6369
Conversation
Created using spr 1.3.6-beta.1
Put them here rather than in `nexus-auth` so that the upcoming nexus-external-api crate has fewer dependencies. Pull Request: oxidecomputer#6369
Adding Dave as well since we discussed where to put this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, but any reason not to put this into nexus-types
?
I did consider that! IIRC it caused nexus-types to pull in a number of extra dependencies, but I'll double-check. |
It's only 3 extra build units ( |
Created using spr 1.3.6-beta.1
At long last, here's the last OpenAPI document converted into a trait: the Nexus external API. This is a fairly large change, but with all the prerequisites in place the conversion is overall pretty mechanical. I did need to move some types around, but the bulk of the PR is just adding the very large external API trait. This PR also adds a `.git-blame-ignore-revs` entry corresponding to #6372, so that the indent doesn't ruin blame in the GitHub web view. (You can configure this locally as well with `git config blame.ignoreRevsFile .git-blame-ignore-revs`.) In a subsequent PR I'll remove the old instructions. Depends on: * #6355 * #6364 * #6369 * #6370 * #6372 Co-authored-by: David Crespo <[email protected]>
Put them here rather than in
nexus-auth
so that the upcomingnexus-external-api crate has fewer dependencies.