[#5333 2/6] Region snapshot replacement omdb cmds #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some commands to omdb related to region snapshot
replacement:
Usage: omdb db region-snapshot-replacement [OPTIONS] <COMMAND>
Commands:
list List region snapshot replacement requests
status Show current region snapshot replacements and their status
info Show detailed information for a region snapshot replacement
request Manually request a region snapshot replacement
`list` will list all region snapshot replacement requests, along with
request time and state
`status` will show a summary of all non-complete region snapshot
replacements, along with their state and progress.
`info` will show details for a single region snapshot replacement.
Finally, `request` will request that a region snapshot be replaced, and
return the ID of the replacement.
leftwo
approved these changes
Aug 9, 2024
|
|
||
| datastore | ||
| .insert_region_snapshot_replacement_request_with_volume_id( | ||
| opctx, |
There was a problem hiding this comment.
This just puts an entry in the table, but there is no action taken on it yet, right?
There was a problem hiding this comment.
Correct, no action is taken until the "region snapshot replacement start" background task picks it up.
Note that all sub command is now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some commands to omdb related to region snapshot replacement:
listwill list all region snapshot replacement requests, along with request time and statestatuswill show a summary of all non-complete region snapshot replacements, along with their state and progress.infowill show details for a single region snapshot replacement.Finally,
requestwill request that a region snapshot be replaced, and return the ID of the replacement.