Track more kinds of datalinks on a sled #6208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
force-pushed
the
track-more-sled-datalinks
branch
2 times, most recently
from
4c85d82 to
14bedbb
Compare
- Drop the old `physical_data_link:*` timeseries, in favor of an
expanded `sled_data_link:*`. This includes the sled identifiers, and
also the _kind_ of link, which incorporates physical, VNIC, and OPTE
devices. Expunge the old timeseries.
- Make the existing metrics manager into a small wrapper around a
background task. Add message types for asking the task to start / stop
tracking various things, for now just VNICs and OPTE ports. Physical
links can also be tracked (but not untracked), which the sled agent
does immediately after creating the task.
- Add the metrics request queue to the instance manager, instance, and
instance runner, and have the runner start / stop tracking the
control VNIC and OPTE ports after booting the zone and before stopping
it respectively.
- Add the metrics request queue to the probe manager, and also start /
stop tracking the links in the zones.
- Add the metrics queue to the service manager. This one is more
complicated, because this object has to exist before the `SledAgent`
object itself, in order to start the switch zone. Instead, the manager
is provided the queue when it's notified that the `SledAgent` exists,
and at the same time tries to use the queue to notify the metrics task
about the control VNIC that must have already been plumbed into the
zone. The service manager also tracks / untracks the VNICs and OPTE
ports for the _Omicron_ zones it starts, which is much simpler.
- Add some helper methods into the `{Running,Installed}Zone}` types for
listing the names of the control VNIC, bootstrap VNIC, and any OPTE
port names. These are used to tell the metrics task what links to
track.
- Clean up a few straggling comments or references to the VNICs that
were previously required between OPTE ports and the guest Viona
driver. Those were removed in #5989.
bnaecker
force-pushed
the
track-more-sled-datalinks
branch
from
14bedbb to
26bc426
Compare
|
In addition to the units I added in the PR, I did a couple of quick tests installing the whole control plane on my dev machine. Here's what we see when starting everything up: I also created and then started / stopped an instance a few times, and we can see the following: That's the control VNIC and OPTE port for the guest being added / removed when the instance is started and stopped. |
There was a problem hiding this comment.
Still going through this @bnaecker, but adding the first runthrough.
- Hashmap over B-tree map - Return indicator of send failure, log failures to send at call site.
|
I'm going to merge with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
physical_data_link:*timeseries, in favor of an expandedsled_data_link:*. This includes the sled identifiers, and also the kind of link, which incorporates physical, VNIC, and OPTE devices. Expunge the old timeseries.SledAgentobject itself, in order to start the switch zone. Instead, the manager is provided the queue when it's notified that theSledAgentexists, and at the same time tries to use the queue to notify the metrics task about the control VNIC that must have already been plumbed into the zone. The service manager also tracks / untracks the VNICs and OPTE ports for the Omicron zones it starts, which is much simpler.{Running,Installed}Zone}types for listing the names of the control VNIC, bootstrap VNIC, and any OPTE port names. These are used to tell the metrics task what links to track.