[oximeter] turn API into a trait #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
bnaecker
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Looks good, thanks! For the standalone Nexus implementation, I'd do whatever is easiest. That's a developer convenience, and there are only two methods that we need to implement. If there's some way to keep them in sync with the new trait-based server, that would be great, but it's not critical.
|
@bnaecker Thanks. At the moment, it's easiest to just have its own thing. But it's a good data point to consider while determining future Dropshot improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the OpenAPI manager to manage this trait as well.
An interesting question is the standalone Nexus impl also defined by Oximeter
-- should that switch to using the internal API crate? As things stand we'd
have to write tons of methods that just error out, but I have some thoughts on
how to make that easier on the Dropshot side.