[installinator] convert artifact/progress API to a trait #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
sunshowers
commented
Jul 12, 2024
| /// Convert this status to an HTTP result. | ||
| /// | ||
| /// Intended to be called by `report_progress` implementations. | ||
| pub fn to_http_result( |
There was a problem hiding this comment.
I could have turned this logic into living on the trait, but in this case that extra work seems unnecessary.
sunshowers
deleted the
sunshowers/spr/installinator-convert-artifactprogress-api-to-a-trait
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To retain consistency with all of the other APIs, I've changed the name to just
installinator-api.artifactwas the case at first but the same API is nowalso used for progress reporting, so it's no longer quite accurate.
We had this indirection going on that's no longer necessary. We also don't need
to have the installinator-artifactd binary that generated the OpenAPI document,
since the manager takes care of all of that.