RSS: Reuse SNAT IPs until port range is exhausted #6037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, RSS would step both the IP and the port range when assigning SNAT IPs to boundary NTP zones. E.g., on a4x2:
After the change, we reuse the IP and only step the ports:
I confirmed both boundary NTP zones still have external connectivity, as expected.
I believe the code here already intended to do this, but accidentally never assigned
self.next_snat_ip
, so always allocated a new IP.