fix up some IAM comments #5972
Merged
fix up some IAM comments #5972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahl
reviewed
Jun 28, 2024
Comment on lines
873
to
874
| /// Built-in users are identities internal the system, used when the control | ||
| /// plane performs actions on its own behalf |
There was a problem hiding this comment.
Suggested change
| /// Built-in users are identities internal the system, used when the control | |
| /// plane performs actions on its own behalf | |
| /// Built-in users are identities internal to the system, used when the control | |
| /// plane performs actions on its own behalf |
consider "on its own behalf" -> "autonomously"?
|
I imagine we'll need some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Props to @bnaecker for spotting the error in the authz block comment.
While looking for more context about that, I found this other error. The description about built-in users was just wrong. (It seems to describe local-only users.) @ahl do you want to take a look at this, since it's kind of a weird thing it's describing?