clean up dpd-client #5951
Merged
clean up dpd-client #5951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahl
commented
Jun 25, 2024
| @@ -44,20 +37,16 @@ impl Client { | |||
| pub async fn ensure_nat_entry( | |||
There was a problem hiding this comment.
I'm not sure it makes a ton of sense to layer custom methods on top of the progenitor methods.. but maybe this is fine.
jmpesp
approved these changes
Jun 26, 2024
| /// | ||
| /// nat_ipv[46]_delete are not idempotent (see oxidecomputer/dendrite#343), | ||
| /// but this wrapper function is. Call this from sagas instead. | ||
| pub async fn ensure_nat_entry_deleted( |
There was a problem hiding this comment.
interesting, was this not used anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.