Add tests for ClickHouse schema upgrades #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bnaecker
commented
Jun 22, 2024
bnaecker
commented
- Adds a check that verifies the SQL contained in each upgrade. This does the basic sanity checks like: one statement per file, no data modifications, but doesn't actually apply the upgrades.
- Adds another test that ensures that the set of tables we arrive at either by upgrading or directly initializing the latest database version are the same.
- Adds a check that verifies the SQL contained in each upgrade. This does the basic sanity checks like: one statement per file, no data modifications, but doesn't actually apply the upgrades. - Adds another test that ensures that the set of tables we arrive at either by upgrading or directly initializing the latest database version are the same.
zeeshanlakhani
approved these changes
Jun 22, 2024
karencfv
reviewed
Jun 24, 2024
| const FIRST_VERSION: u64 = 3; | ||
| for version in FIRST_VERSION..=OXIMETER_VERSION { | ||
| let upgrade_file_contents = Client::read_schema_upgrade_sql_files( | ||
| log, false, version, SCHEMA_DIR, |
There was a problem hiding this comment.
It appears we're only testing single node and not replicated here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.