move specific background tasks into submodule #5930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I figured you meant a crate, but “submodule” struck fear into my heart. |
hawkw
approved these changes
Jun 25, 2024
|
Noting for myself: I think this is ready to go, but I want to merge it manually once checks finish because this seems like a candidate for git to automatically create a semantic mismerge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic background task subsystem has grown enough (and will grow more soon) that it seems worth separating out the generic bits from the specific background tasks. I've also reorganized some of the generic bits in a way at least I find a lot clearer. I found it hard to keep track of what was in "init" vs "common" since both are part of the "common" set and also used in initialization.