Add background task to collect Cockroach zone node IDs #5857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjstone
approved these changes
Jun 5, 2024
| // told this is "unlikely to change for some time". | ||
| // https://github.com/cockroachdb/cockroach/issues/124988 requests that | ||
| // this be documented (or an alternative be documented / provided). | ||
| let row = client |
There was a problem hiding this comment.
I'm slightly worried about this command being routed to another node, which can happen in some cases when a request is forwarded to the raft leader for the quorum containing the data.
While it would be super weird for that to happen in this case, I worry about accidental breakage. For extra assurance, maybe we should assert that this node id matches the current address we are contacting. I'm not sure if we can do that outside the status cli though.
Am I being too paranoid here?
There was a problem hiding this comment.
Not sure if you're being too paranoid, but I think this is easy enough to check for. I took a stab at it in 70c7558
There was a problem hiding this comment.
Thank you! This looks excellent.
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
|
||
| //! Background task for collecting the Cockroach Node ID for running CRDB zones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in yesterday's update huddle - this adds an endpoint to the
cockroach-adminserver which internally uses the undocumentedcrdb_internal.node_id()function to get the node ID of its local runningcockroach, and adds a background task to Nexus to collect zone ID <-> node ID mappings for every cockroach zone in the current target blueprint.This is a prerequisite for decommissioning, but currently has no consumers.