move the verify-libraries CI check into releng #5779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
approved these changes
May 15, 2024
| @@ -3,7 +3,6 @@ | |||
| #: name = "a4x2-deploy" | |||
| #: variety = "basic" | |||
| #: target = "lab-2.0-opte-0.27" | |||
| #: rust_toolchain = "stable" | |||
There was a problem hiding this comment.
Looks like the other a4x2 job uses a specific toolchain version in lieu of stable. Did you intend to delete this and pin to 1.77.2, like a4x2-prepare.sh?
There was a problem hiding this comment.
a4x2-deploy is similar to the deploy job in that neither needs a Rust toolchain, because they're both targeting lab environments where the ramdisk image does not contain any compilers. (Both these jobs get all their artifacts compiled on a job with a non-lab target.)
(This is merely a cleanup that is tangential to the purpose of this PR, but should get done anyway.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of the build-and-test job,
cargo xtask verify-librariesis a bit of an unrelated operation, because it's building all of the binaries in between building all of the test binaries and then running all of the test binaries.I had initially considered moving it to its own Buildomat job, but then realized that this is really a release engineering check; we already have built most of the binaries (in particular, Nexus, the one that takes the longest to build) in order to package them up, so we can manage to build the handful of extra utility binaries and perform the checks while the host OS image builds.
This should improve the build-and-test (helios) job by about 10 minutes while having negligible impact on the tuf-repo job, and will also eliminate a new and exciting source of test flake we've seen where
timeout 10mis getting hit, presumably because we continue to write software.