-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPC Subnet Routing [1/2] -- RPW and System Routers #5777
Merged
Merged
Changes from 42 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
76106b1
Clear XDE underlay when destroying virtual hardware
FelixMcFelix 0afee1b
Merge branch 'main' into felixmcfelix/opte-underlay-lock
FelixMcFelix 94e1808
Pull in latest OPTE after merge.
FelixMcFelix b67f416
Bump OPTE and related.
FelixMcFelix 5f7cfa8
Compat with newer OPTE, more believable router rules
FelixMcFelix 16e0107
VPC Subnet route reconcile.
FelixMcFelix 22b71bb
We now have valid, sane, default system routes
FelixMcFelix 160853b
Start refreshing API specs
FelixMcFelix 034dd0f
Iterating.
FelixMcFelix 87d9b26
Route resolution (but not actual installation)
FelixMcFelix 568f44c
Wrong ID in router initialisation.
FelixMcFelix 2a25d74
Rule insert/delete with OPTE.
FelixMcFelix c718c8d
Correctly instantiate router rules if existing
FelixMcFelix 06eaaab
Feed Clippy.
FelixMcFelix 38beadd
Comment adapted.
FelixMcFelix 17489cb
The backing code for a generational RPW
FelixMcFelix 006b1ca
Iterating.
FelixMcFelix c7de875
Trigger RPW in all the right spots.
FelixMcFelix 40edbc8
Unpublish VPC routers API.
FelixMcFelix 3b3abb1
Fixup broken tests.
FelixMcFelix be9f8ab
Accidental local state...
FelixMcFelix f433b38
Unsubscribe routes from sled when ports are removed.
FelixMcFelix 62ca9f0
Migration query for subnet route creation.
FelixMcFelix 2c06ff4
Rework migration slightly.
FelixMcFelix 0e8d1ad
Bump OPTE to include latest perf work.
FelixMcFelix 7b32e09
Merge branch 'main' into felixmcfelix/opte-underlay-lock
FelixMcFelix f7646ef
Merge branch 'felixmcfelix/opte-underlay-lock' into felixmcfelix/vpc-…
FelixMcFelix 2537222
Self-review pt.1.
FelixMcFelix f217bd1
Self-review pt.2.
FelixMcFelix b549044
Test route resolution.
FelixMcFelix f02535e
Accidentally ended up on the wrong maghemite.
FelixMcFelix 880378a
Hook VPC checks into sim-sled-agent, instance networking tests.
FelixMcFelix 08c982e
Correctly cleanup after new tests...
FelixMcFelix e886d16
Fix custom router listing.
FelixMcFelix 321cb16
Merge branch 'main' into felixmcfelix/vpc-subnet-routing
FelixMcFelix f21ef51
Merge branch 'main' into felixmcfelix/vpc-subnet-routing
FelixMcFelix cca764f
Bump image.
FelixMcFelix 2425016
Forgot some maghemite SHAs...
FelixMcFelix feb455f
Merge branch 'main' into felixmcfelix/vpc-subnet-routing
FelixMcFelix 30e4043
Minor fixes post-merge.
FelixMcFelix 0057228
Review feedback.
FelixMcFelix 15bb2ee
Merge branch 'main' into felixmcfelix/vpc-subnet-routing
FelixMcFelix 8162a23
Review feedback: typed RouterKind instead of Option abuse
FelixMcFelix e1971bc
Bump Maghemite.
FelixMcFelix 899d367
Merge branch 'main' into felixmcfelix/vpc-subnet-routing
FelixMcFelix 70263a2
Better conflict resolution on Nexus-managed subnet route names
FelixMcFelix 62de75e
Unearthed a nice li'l bug during migration on london
FelixMcFelix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting for posterity, Kyle and I discussed this offline: it seems like the Option here doesn't really make it clear how the field will be used in the event that it is
Some(value)
orNone
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 8162a23 -- we're now using
RouterKind::System
andRouterKind::Custom(IpNet)
which is far clearer.