Insert a default allowlist during schema migrations #5700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On new racks, an allowlist for user-facing services is populated during RSS. Nexus waits for the allowlist to exist before starting its external server, to ensure that the rules exist from the first request. On existing racks, however, RSS has already run and the allowlist is never inserted, causing Nexus to wait forever. This commit adds a one-time insertion of the default allowlist (allowing any external traffic) as a data-only DB migration. An existing allowlist is not modified to preserve existing allowlists during further migrations.
bnaecker
force-pushed
the
insert-default-allowlist-on-migration
branch
from
14af9b5 to
90ca30b
Compare
rcgoodfellow
approved these changes
May 5, 2024
andrewjstone
approved these changes
May 5, 2024
There was a problem hiding this comment.
Makes sense to me. Thanks for all the heroic work getting this right @bnaecker
…and is already captured by the driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On new racks, an allowlist for user-facing services is populated during RSS. Nexus waits for the allowlist to exist before starting its external server, to ensure that the rules exist from the first request. On existing racks, however, RSS has already run and the allowlist is never inserted, causing Nexus to wait forever.
This commit adds a one-time insertion of the default allowlist (allowing any external traffic) as a data-only DB migration. An existing allowlist is not modified to preserve existing allowlists during further migrations.