remove the newtype uuid from the public API #5689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
approved these changes
May 2, 2024
|
Good idea for now. I think that at some point there was definitely discussion of being able to namespace uuids within the public API. |
There was! I don't think we reached any determination, and I don't think the newtype uuids match my recollection of that discussion (though they would be a useful mechanism on the way there). |
|
Perhaps discussions about the public API could be discussed/brought up in the Product eng sync? Some decisions could change the way our language SDKs look like, and have customer impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we want to include newtype UUIDs in the public API. There's only one and it was added (I think by accident) recently.